node icon indicating copy to clipboard operation
node copied to clipboard

Missing `Http2ServerResponse.setHeaders()` fixed

Open Imperat opened this issue 1 year ago • 5 comments

This fixes missing setHeaders:

  • https://github.com/nodejs/node/issues/51573

Imperat avatar Jan 27 '24 07:01 Imperat

Review requested:

  • [ ] @nodejs/http
  • [ ] @nodejs/http2
  • [ ] @nodejs/net

nodejs-github-bot avatar Jan 27 '24 07:01 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56933/

nodejs-github-bot avatar Jan 27 '24 17:01 nodejs-github-bot

Can you fix linting and the first commit message?

mcollina avatar Jan 27 '24 22:01 mcollina

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

github-actions[bot] avatar Apr 29 '24 11:04 github-actions[bot]

(waiting for action from author)

redyetidev avatar Apr 29 '24 11:04 redyetidev

Funny enough this PR's github action got stuck for some reasons and therefore stall action to close the PR never happened. Since this is an oz fellow, I reached out to him to see if he's still interested to continue his PR, if not I will manually close it.

update: @Imperat replied to me and still interested to move the PR forward 👍

jakecastelli avatar Aug 17 '24 15:08 jakecastelli

Hi @jakecastelli @mcollina Thanks for having a look at this PR :pray: I've updated linting, merged the latest main branch and applied suggestions from @meyfa

Hi @mcollina

Can you fix linting and the first commit message?

Do you have a link to a doc describing how should look the commit message? I did not find anything relevant in docs.

Imperat avatar Aug 18 '24 06:08 Imperat

Hi @Imperat, first commit message was referred to the project contributing commit guideline. In this PR, the subsystem should be http2 and the commit could be http2: add missing setHeaders (just a suggestion).

Also, the project requires rebase than merge, would you mind rebasing instead of merging and squash your changes into a single commit before you fix the first commit message, if you need any help please let me know.

jakecastelli avatar Aug 18 '24 07:08 jakecastelli

Funny enough this PR's github action got stuck for some reasons and therefore stall action to close the PR never happened. Since this is an oz fellow

FWIW https://github.com/nodejs/node/issues/54425

redyetidev avatar Aug 18 '24 11:08 redyetidev

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.32%. Comparing base (e4f61de) to head (7886934). Report is 4 commits behind head on main.

Files Patch % Lines
lib/internal/http2/compat.js 78.94% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #51576      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         648      648              
  Lines      182321   182340      +19     
  Branches    34971    34981      +10     
==========================================
+ Hits       159222   159223       +1     
- Misses      16374    16388      +14     
- Partials     6725     6729       +4     
Files Coverage Δ
lib/internal/http2/compat.js 96.50% <78.94%> (-0.34%) :arrow_down:

... and 25 files with indirect coverage changes

codecov[bot] avatar Aug 18 '24 19:08 codecov[bot]