isic-archive
isic-archive copied to clipboard
pug-lint bugs
Girder's .pug-lintrc
file enables the rules requireLowerCaseTags
and validateAttributeSeparator
, but both have buggy behavior.
-
requireLowerCaseTags
fails with our use of SVG definitions elements. This is a known issue upstream: https://github.com/pugjs/pug-lint/issues/108 -
validateAttributeSeparator
is bugged when usingmultiLineSeparator
. First, the tokenizer is buggy, causing unexpected matching of additional indentation whitespace. Second, themultiLineSeparator
argument needs to take a RegEx, in order to accommodate variable spacing due to indentation.
To fully resolve this issue:
- the bugs must be fixed upstream
- upstream pug-lint must make a new release
- Girder must upgrade to the new release
- this plugin must upgrade to the new Girder
- the commit https://github.com/ImageMarkup/isic-archive/pull/406/commits/42d1adfad26d4830675dccc2051bfd61fca52f22 must be reverted