James J comments

Results 6 comments of


                                            James J

Add an implementation of Stack Blur as a `juce::ImageEffectFilter`

@sudara > I'm wondering what size image is this on? It would be nice to know if blurring X amount of pixels is possible at > 60fps... Those benchmarks were...

This line is missing the `Args` template argument on `std::forward`

The `RealtimeObject` identifer doesn't seem to have been defined anywhere. I fixed this by replacing ``` 34 return RealtimeObject (false, std::forward(args)...); ``` with ``` 34 return RealtimeMutatable(false, std::forward(args)...); ``` and...

"--timeout-ms -1" doesn't work as stated.

No, it still outputs the "Missing argument" message!

Add THEN_REQUIRE and AND_REQUIRE macros for shorter more explicit code

Should the `AND_REQUIRE` macro really be `AND_THEN_REQUIRE`? It's a bit cumbersome I know (especially if you also add `AND_THEN_REQUIRE_FALSE`) but `AND_REQUIRE` sounds more like it should come after a normal...

Add THEN_REQUIRE and AND_REQUIRE macros for shorter more explicit code

Have you thought of adding `THEN_CHECK` as well?

Allow daisy-chaining when adding children to ValueTrees

This would go nicely with https://github.com/juce-framework/JUCE/pull/1333 to make constructing value trees even cleaner: ```cpp juce::ValueTree {"Root"} .setProperty("foo", 10) .setProperty("bar", 20) .appendChild (juce::ValueTree {"Branch"} .setProperty ("x", y) .appendChild (juce::ValueTree {"Leaf"})) .addChild...