paragraph icon indicating copy to clipboard operation
paragraph copied to clipboard

Stop using Werror and Wall

Open dpryan79 opened this issue 3 years ago • 0 comments

Paragraph is currently not compilable because both it and the vendored graph-tools use -Werror -Wall. Patching the main paragraph CMakeLists.txt still yields:

2022-11-20T17:33:07.3654873Z 17:33:07 BIOCONDA INFO (OUT) /opt/conda/conda-bld/paragraph_1668965108268/work/build/external/graphtools-src/src/graphalign/GaplessAligner.cpp: In function 'std::__cxx11::list<graphtools::GraphAlignment> graphtools::getBestAlignmentToShortPath(const graphtools::Path&, int32_t, const string&)':
2022-11-20T17:33:07.3656847Z 17:33:07 BIOCONDA INFO (OUT) /opt/conda/conda-bld/paragraph_1668965108268/work/build/external/graphtools-src/src/graphalign/GaplessAligner.cpp:64:32: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
2022-11-20T17:33:07.3658286Z 17:33:07 BIOCONDA INFO (OUT)    64 |     const auto end_extension = static_cast<const int32_t>(query.length() - start_pos - path.length());
2022-11-20T17:33:07.3659076Z 17:33:07 BIOCONDA INFO (OUT)       |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-11-20T17:33:07.8570655Z 17:33:07 BIOCONDA INFO (OUT) cc1plus: all warnings being treated as errors
2022-11-20T17:33:07.8646032Z 17:33:07 BIOCONDA INFO (OUT) make[2]: *** [external/graphtools-build/CMakeFiles/graphtools.dir/build.make:76: external/graphtools-build/CMakeFiles/graphtools.dir/src/graphalign/GaplessAligner.cpp.o] Error 1

That's since the vendored graph-tools also has this. Please just remove these, you can't possibly hope to keep up with every compiler out there.

dpryan79 avatar Nov 20 '22 17:11 dpryan79