Igor Baratta

Results 20 comments of Igor Baratta

I think this can only be caused by user error (non consistent input). Checking for correctness of inputs requires communication, so it would be expensive.

I'm closing this now. I've initiated work on a new branch, aiming for fewer modifications thanks to @jorgensd's PR.

Hi @nils-imhoff , If the exception classes are only used within a single file, I think they might be placed at the beginning of the file. Alternatively, you might create...

Should we use an interface similar to the older one? eg: ``` class PointSource { public: PointSource(std::shared_ptr V, const std::vector sources); PointSource(std::shared_ptr V0, std::shared_ptr V1, const std::vector sources); ~PointSource() =...

> This will require `MatrixCSR` to recompute its sparsity and some of its internal data (insert position for finalize for example). Yes, I think that's the main idea of the...

I'm working on it. The demo is actually over-complicated and requires some simplifications. But I'll also review the tolerances used.

I have looked only at `demo_axis`, but I'm thinking that similar enhancements might apply to `demo_pml` as well. I plan to address these issues and submit a pull request in...

> Sir this is actually my first pr and I don't know what happened since it already showed closed to me. It would'be really helpful if anyone can help I...

Simple "failing" example that we could test in c++: ```c++ #include #include #include int main() { int handle = basix::register_element("Lagrange", "triangle", 1); int tdim = 2; int num_points = 2;...

I like the idea of enabling full C++ 20 support. But I also think it can make it difficult to build basix on non `x86_64` computers. I think it may...