WPEBackend-fdo
WPEBackend-fdo copied to clipboard
Igalia
 **Case of use:** 1. WebView 1 load a Page Domain1/page (surface 1) 2. WebView 1 load a Page Domain2/page (surface 2) (but is filtered by the Content Filters Policy...
While [reviewing a PR](https://github.com/Igalia/WPEBackend-fdo/pull/148#discussion_r611050105) I noticed that the CI is not running for PRs filed from forked repositories.
I would like to point out that identifiers like “[`__initialize_egl_h__`](https://github.com/Igalia/WPEBackend-fdo/blob/0e10c424223dbc663ea6f4f2f299c99cd4e14718/include/wpe/initialize-egl.h#L30 "Update candidate")” and “[`__wpe_fdo_h__`](https://github.com/Igalia/WPEBackend-fdo/blob/0e10c424223dbc663ea6f4f2f299c99cd4e14718/include/wpe/fdo.h#L30 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
Using `wl_display_connect_to_fd()` may fail, and currently errors are being ignored. At least it would be good to have some logging instead of continuing ahead silently.
Probably we would want to use [GTK-Doc](https://developer.gnome.org/gtk-doc-manual/stable/), which despite the name does not need GTK+ at all. That would allow cross-linking to the WPE WebKit API reference if needed. See...