Nick Avramoussis
Nick Avramoussis
Hey @peytondmurray - sorry for the delayed reply. Thanks a lot for outlining the process, this all sounds good to me! I confirmed today with the other maintainers that it...
Hi @asztalosdani - sorry you've run into this. I believe you've done everything correctly and this is instead an issue with that specific node (the OpenVDB Visualize node). As far...
> Sorry, I'm late to the game but I'm going to voice my dissent here anyways. First change I see is in `openvdb/Exceptions.h` which got `` modified to `"openvdb/version.h"` instead....
> I think I disagree with this change generally until pending a review of that these changes are doing what we actually intend on. I'm not entirely sure what "tweaking...
> I've made the suggested change that @e4lam pointed out (in `openvdb/Exceptions.h`). But I'll set the PR back to draft, until the discussion is resolved. You may find that simply...
> If we can't have upwards relative include paths, then I don't see why we should make any of these changes at all since it defeats the purpose of changing...
@e4lam thanks very much for the tests. I thought this behaviour was explicit with _default_ system dirs, not necessarily dirs given with `-isystem` i.e: ``` > gcc -E -Wp,-v -...
Yes I just wanted to clarify that, as it stands, this change should have absolutely no impact - contrary to what was originally implied. > FWIW, I'd like to point...
https://github.com/AcademySoftwareFoundation/openvdb/pull/646 will address (2)
Hey @e4lam regarding (1), I was able to get this working with no installation changes, provided I have the following set: ``` # Assumes vcpkg/installed/blah is already on path 1...