Nick Avramoussis
Nick Avramoussis
Pinning this as we very much still need a solution
As our new boost minimum is 1.73 (from VDB 10) I'll close this. We'll hopefully be moving to pybind11 in the very near future, but please do create new issues...
Closing this issue as a duplicate of #1160 - basically we need to start shipping proper Config files. Going to use 1160 to track this
> Hi Nick, I took a look at the code last week and this looks good to me in general. Sorry for the delay in reviewing. > > When attempting...
Don't seem to be able to reproduce this. Here's my CMake command: CMake Config ``` -D CMAKE_BUILD_TYPE=Release -D CMAKE_INSTALL_PREFIX=/Users/nicholasa/openvdb_install -D CMAKE_CXX_FLAGS_INIT=-Wno-deprecated-declarations -D OPENVDB_CXX_STRICT=ON -D OPENVDB_CORE_SHARED=ON -D OPENVDB_CORE_STATIC=OFF -D OPENVDB_AX_SHARED=ON -D...
@danrbailey sorry, can reproduce this now! Will investigate
@danrbailey thanks for catching this, I've fixed this now!
@danrbailey @e4lam this is still a problem right? We're building with `/permissive-` now but the CI is passing, presumably because we're not building with VS 2022. We should fix this...
Actually, just checked the job logs and looks like the github runners are running 2022? https://github.com/AcademySoftwareFoundation/openvdb/actions/runs/3258602101/jobs/5350816908 But the builds are passing?
Awesome, thanks @e4lam - what was the fix for this issue in those PRs? My understanding was we could reproduce this error using VS 2022 with `/permissive-` which we are...