Ryan Wilson

Results 52 comments of Ryan Wilson

Hi! I love that you did this :) I've been working on something as well; but it's not working anymore :( https://github.com/Icehunter/machina Maybe we could combine some ideas? :D I...

> Just wanted to note on here it looks like just a rebase, without addressing the review comments yet. I presume that will come in follow up commits? Yes, working...

@dougwilson I found all the comments I think needed to be fixed, except 2 perhaps that I'll work on tonight. 1. the on('data') callback which I think doesn't need a...

@dougwilson Is there anything more you see for this PR to have? @sogaani with regards to your comment on the error status code; it seems to be a big edge...

Eh! Sorry; I did leave the on('data') callback as is in the test, but I removed all the logs and I believe covered everything you had commented on in the...

> @Icehunter, for the clarity that #129 is not in this PR, the description should change: > > > updated PR with rebase from express/compress:master to handle #128 ~and #129~...

Can someone update this or get another one open to achieve the same results? It's been a known issue for quite some time and prevents using http2 with server framework...

Going to test this out now: https://github.com/Icehunter/ffxivapp-memory/commit/80d73cdc3b9e4ef3dff4780539ff958e575b1ea2

@ChristianIvicevic I just saw this... omg... been so busy with family but I'm back playing now :D BitMask for combat flags is now +16E7, the Icon to combine with it...