Ian Wood
Ian Wood
> Arent there any tests that would make it easeier to use `iree-flow-dispatch-region-creation-pipeline`. > > THis matches all my expectations. So this looks good to me! I tried to use...
Currently byo_llvm is failing because llvm isn't being built with any of the PDLL libraries. I think this can be fixed by adding `mlir-pdll` to `LLVM_MLIR_TOOLS` in the [config file](https://github.com/iree-org/iree/blob/94728e34c2e0ea6b91624c78c866b5fddf8236fb/build_tools/llvm/mlir_config.cmake)....
It's probably okay to close it. There are issues with byo llvm and PDLL also doesn't support ops with regions (e.g. linalg named ops), which makes it fairly limited in...
@MaheshRavishankar, I added the check for the number of uses because `inlineBlockBefore` erases the block. But, I updated it to clone the block first so the generic is preserved
I changed matchAndRewrite to match against `ExtractOp` because it seemed more natural. There are 2 main complications 1. Extract ops cannot be erased until iteration is finished (this was causing...
Okay, I did some testing because I was having problems even with an updated upstream. For some reason, byo_llvm is able to build and link successfully but then segfaults on...
> > For some reason, byo_llvm is able to build and link successfully but then segfaults on some of the tests. These tests aren't related to PDLL at all either....
I see, the reshape can't propagate past the conv due to non-projected permutation indexing maps. > I was thinking we could have an option to not sink collapseshape through pad...
@MaheshRavishankar I suspect that this is related to [the dispatch](https://gist.github.com/IanWood1/40ee4965a23a4eba4ff71794b52ee6bb) that is now failing to compile after https://github.com/iree-org/iree/pull/21063. Especially since the fix was meant to resolve 2 very similar correctness...
Pre-patch they are going down warp reduction (possible miscompile) and after the patch they are going down tile and fuse (compilation fail)