Ian VanSchooten

Results 829 comments of Ian VanSchooten

@ccondrup Thanks for the PR! It looks like there's a typescript error, if you have a chance to take a look.

Something else must be causing the extra lines. I created a new project with your config settings, and I get the expected output above. To troubleshoot, try running prettier on...

I'm taking a look at your test repo. The only file with more than one import is `layout.tsx`, but it does not have the imports as shown in this issue....

Right, side-effects are never sorted, because the order they are placed in can matter (for example multiple css imports will determine the cascade order, and rearranging them can change how...

@fbartho I was keeping it open due to: > The extra space above the side-effect import is a bit unexpected, and only seems to happen when a line separator is...

@AdaptCharm what solution are you looking for? Just avoiding the extra new line above style (side-effect) imports?

Hi, the reason this plugin was forked from Trivago's version in the first place was that I wanted a tool that did not sort side-effect imports. In general, they are...

Grouping side-effect imports would not be safe, but we do now have `importOrderSafeSideEffects` if you want to treat some of them as safe-to-reorder. I'd be happy to review a PR...

@shrpne sorry, could you open a new issue explaining what you're trying to accomplish, with desired before/after, and we can discuss there?