Ian VanSchooten

Results 816 comments of Ian VanSchooten

I don't have a strong opinion here, and I expect that reasonable people could disagree on how to order these. We wouldn't want to add an option to control this,...

🦗 Sounds like maybe someone should fork it and start pulling in some of the open PRs, perhaps.

It seems this PR can be closed, fwiw. Node 20 was merged in https://github.com/Apple-Actions/import-codesign-certs/pull/64.

Gotcha. Then maybe the title is just out of date or I misunderstood it. :homerbackingaway:

I think it could be considered a "bugfix", though we might want to release in a minor. Even prettier itself allows formatting changes between versions. We should make our stance...

Yes, but that's how we ended up with a bajillion options previously, and we worked hard to remove them. Prettier itself is opinionated and has very few options, and we...

Thanks for the PR, @TSenter. Can you describe what issue this is solving for you?

Thanks, I just like to have a description in PRs about the changes being made.

The change seems reasonable, but I asked for some instructions on how to test.

This is also a problem when re-writing the file. I am operating on a microsoft manifest, which has a namespace used in element names like this: ```xml permonitorv2,permonitor ``` But...