Ian Krieger
Ian Krieger
My only concern is this immediately breaks BSA and "agency" like advertisers. We would basically need agencies to have an advertiser "account" that contains multiple named advertisers they are setting...
Yes you can, @shubrautt
I think in cases where we are setting a form value, we should `await` them, making the onClick async: `onClick{async () => ...}`
I don't think we need that rule, but If you could provide an example of a line in the codebase that is failing because this check does not exist, we...
Hmm, well since I do wish for the value updates to propagate, and I do not like the workarounds I've seen, I am fine with `{ "checksVoidReturn": false }` Thank...
I think void in this scenario is ok, as any actions we want to take should be in the hook definition.
@iambrianfung this would assume that all creatives also have the same `eTLD+1`, is this an expectation as well?
We need to factor in how much an advertiser has spent is not synchronous, and can have significantly changed by the tine they go to update this. I want to...
Going to let users extend their end date, with a warning that it may never reach it
This should be fixed as of: https://github.com/brave/ads-serve/pull/2901