Andreas Renberg

Results 23 comments of Andreas Renberg

I'm hesitant to add this feature. There is no delay between requests, so if I'm thinking correctly, the script will continue to send out request after request as many times...

As for the **why**, how many issues were you importing at once? The GitHub API has a maximum number of requests per day `*`, so if the script exceeded that...

Old issue details (just changed this to a checklist in the main issue's body): **Pass config file location as argument** This allows the import script to be in one location,...

@brianreavis Actually, Wormss is correct. `Number`, `uint`, and `int` Vectors are registered as completely different classes and optimized in some fashion to be as fast as possible. Every other Vector...

@WORMSS I hit the submit button to early, but went back and edited the message. You were simply too quick to the keyboard. ;) I noticed another problem with the...

@brianreavis That's because the `test` variable is `null`. You need to set it to a non-null value for the code to work properly: ``` var test:Vector. = null; // all...

Third version. Does this look better? I switched to a different cleaning function for mail input which seems to suit the purpose much better. http://mattgeri.com/blog/2012/01/escaping-input-to-the-php-mail-function/

If either of you are still having problems with it, making it compatible is actually a really simple fix: https://github.com/IQAndreas/jekyll-static-comments/commit/ce7808d9ef7a127bac52de470e6d83cbfaf78457 The plugin should also still be compatible with the older...

> You won't get any attributes if you pass in nil. Actually, you will, since Jekyll's version of `to_liquid` looks [like this](https://github.com/mojombo/jekyll/blob/master/lib/jekyll/convertible.rb#L101): ``` ruby (attrs || self.class::ATTRIBUTES_FOR_LIQUID) ```

> https://github.com/mpalmer/jekyll-static-comments/pull/15 should do it. Actually, your code isn't compatible with previous versions of Jekyll (and for reference, Octopress still uses `Jekyll 0.12.0`). I added a fix for reverse-compatibility with...