jekyll-static-comments icon indicating copy to clipboard operation
jekyll-static-comments copied to clipboard

Plugin crashes for Jekyll >= 1.1.0

Open matze opened this issue 11 years ago • 4 comments

The static_comments.rb plugin crashes with

$ jekyll serve --trace
Configuration file: /home/matthias/blog/_config.yml
            Source: /home/matthias/blog
       Destination: /home/matthias/blog/_site
      Generating... /var/lib/gems/1.8/gems/jekyll-1.1.2/bin/../lib/jekyll/post.rb:255:in `to_liquid': wrong number of arguments (1 for 0) (ArgumentError)

with Jekyll version 1.1.0 and 1.1.2. Versions 1.0.0 through 1.0.4 work fine.

My gut tells me it's that change that leads to the problem.

matze avatar Aug 14 '13 08:08 matze

I have exactly the same problem. I use Jekyll version 1.2.1.

kctong529 avatar Sep 24 '13 16:09 kctong529

If either of you are still having problems with it, making it compatible is actually a really simple fix: https://github.com/IQAndreas/jekyll-static-comments/commit/ce7808d9ef7a127bac52de470e6d83cbfaf78457

The plugin should also still be compatible with the older versions of Jekyll.

IQAndreas avatar Sep 28 '13 07:09 IQAndreas

Nice! Would be great though to see this merged upstream.

matze avatar Sep 28 '13 08:09 matze

Please merge @IQAndreas's solution.

rwmpelstilzchen avatar Oct 29 '13 12:10 rwmpelstilzchen