Siyuan Feng

Results 99 comments of Siyuan Feng

Refactored. Now AttentionKVCache and RNNState have the same base class. would be great if @MasterJH5574 @tqchen Can take a look

Thanks for the PR. I'm working on the ut fix. I would open a new PR including: 1. bash fix in this PR 2. ut fixes to ensure all test...

Thanks @liushengjiezj for finding this. It's a bug with no doubt and it fails even after the unity transition. Could you please send a patch to fix it?

Updates: https://github.com/apache/tvm/pull/16572

We only simplify the Expr, but keep the stmt. Some similar behavior is about the unit loops. We remove unit loops at a lowering pass instead of simplification

The second one looks good to me. Could you send a PR to fix it?