tvm icon indicating copy to clipboard operation
tvm copied to clipboard

[CI Problem] python unit tests only run the cases in the arith folder

Open liushengjiezj opened this issue 1 year ago • 3 comments

The ArmChina team recently synchronized the community's new code and found that python's unittest was split from one folder into multiple folders and traversed multiple folders to run in the bash script(tests/scripts/task_python_unittest.sh). 图片

But in line 57, we found that if the for statement is written like this, only the first element in the array will be looped. In other words, running this script will only run the test cases in the arith folder.

We found a recent pipeline to verify the behavior of this script, and indeed only the test cases in the arith folder were run: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cpu/detail/main/1311/pipeline/91/ 图片

Is it intentional to write this way or are there other considerations? @Hzfengsy @tqchen @Johnson9009

Branch/PR Failing

None

Jenkins Link

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cpu/detail/main/1311/pipeline/91/

Flakiness

None

Triage

  • dev:test-infra

liushengjiezj avatar Feb 02 '24 03:02 liushengjiezj

@Hzfengsy We aren't sure if it is a bug, if it is a typo bug, I think we need fix it and check if the Unity branch transformation haven't run these tests too.

Johnson9009 avatar Feb 02 '24 03:02 Johnson9009

Thanks @liushengjiezj for finding this. It's a bug with no doubt and it fails even after the unity transition.

Could you please send a patch to fix it?

Hzfengsy avatar Feb 02 '24 04:02 Hzfengsy

@liushengjiezj Please help to send a patch to change all these thing we find, thanks.

Johnson9009 avatar Feb 02 '24 05:02 Johnson9009