Huite

Results 199 comments of Huite

What would the end result of parsing this be? For the UGRID topologies (1D or 2D), we can construct a grid (Ugrid1d, Ugrid2d) object which contains the topological information and...

With this and a running + plotting utility, it becomes quite easy to make automated comparison calculations: ```python def compare(timml_model, xmin, ymin, xmax, ymax, cellsize): timml_model.solve() converter = ModflowConverter( timml_model,...

I think this could be a useful addition to testing, apart from straightforward analytical solution (such as in: https://github.com/mbakker7/timml/blob/master/notebooks/circular_buildingpit.ipynb) I could make a PR implementing such testing, which would run...

The above obviously requires both flopy and MODFLOW 6, which rather complicate setting up the testing on the CI. Fortunately, we use so little of MODFLOW 6 functionality, that the...

I think my current suggestion would be something along these lines. We introduce a testing_utils namespace. Ideally this lives only in the testing directory, so that people cannot use it...

To disallow the following: ```python grid2d.face_x += 10.0 ``` I think I'd suggest adding the following method to AbstractUgrid: ```python @staticmethod def _immutable_array_view(array: np.ndarray) -> np.ndarray: """ Let's look at...

The area computation in overlap regridding is done in numba_celltree: https://github.com/Deltares/numba_celltree/blob/ab64846dc8297c20a9d445f751bfcf6c1271b39a/numba_celltree/geometry_utils.py#L77 It might make sense to move the code to numba_celltree, since integrating over the sphere surface might be not...

Some tedious details: * There may be multiple topologies present in a single dataset. * These could all be converted into single UgridDataset (since it supports multiple topologies), but this...

For what it's worth, I've implemented this for the cell tree: https://deltares.github.io/numba_celltree/api.html#numba_celltree.CellTree2d.intersect_edges There's another way of intersecting a mesh, which is by finding the intersection with the boundary, "entering" the...

Hi @arthurvd, yes that's correct. The `intersect_edges()` method from the CellTree2d will return the indices which can be used to fetch the values of the faces. Taking a good look,...