Huite

Results 199 comments of Huite

At the risk of "yet another opinion": this doesn't have to be solved in the Julia kernel, right? The essential issue as posted by @visr, to me, seems: > asking...

@Fati-Mon You're right of course, you can measure S-h directly with e.g. a hydropower dam, I hadn't considered that yet! I'll argue there still lies a trap in waiting, since...

I'm not sure why the coverage report is way down, but I've remember seeing sudden changes in coverage reports before (e.g. flopy). I don't think the coverage is super meaningful...

> One more thought, we could consider adding isort and formatting checks using ruff, instead of only checking linting? Running ruff check takes care of this. If I scramble the...

You're right, turns out I was a little confused... isort is part of the linting, but the formatting isn't. To check for the formatting, we need to run `ruf format...

Well, I just got confirmation from the CI that it does check: ``` All checks passed! Would reformat: examples/timml_notebook0_sol.py Would reformat: examples/workshop_nhv/vlaketunnel_functions.py 2 files would be reformatted, 31 files already...

This is due to the fact that `isel` doesn't broadcast, but `.where` does. Might have to solve it by filtering variables based on dimension, then only applying where if the...

> There is the currently private https://github.com/Deltares-research/UGrid.jl that we made at the start of Ribasim. It would be a bit more work, but we could also consider writing it on...

Not sure how feasible this is, but: The primary motivation in decreasing the number of states here is to lower the amount of linear algebra work, right? Smaller systems, faster...