Hugo Granström

Results 161 comments of Hugo Granström

Ahhhh! 😵😱😮 This is so confusing. Can't see how it would affect the time to switch. But Tsit54 isn't strange as yLow isn't what we mean by yLow 😅 Do...

Strange, but great that it works 😊👍 did you change all of the coefficients or was there common ones?

I think we can go with the "most robust" if it works. Can be good to have an integrator that is robust 😄👍😊

I feel like the "most effective" is getting very personal 😂 can be a dangerous rabbit hole to step into

Oh boy, that's a hard nut to crack :/ The entire reason we do the `checkIsValidCode` is to find out if it potentially could be a string instead of an...

Another workaround would be to inspect the code before the check, remove all imports, and then re-insert them again afterwards.

> wait, is this the only reason? what we would do if it is indeed a string? For the string case could we just use an overload (of nbCodeToJs and...

I agree that the `nbJs-` prefix is good and makes more sense overall :+1: So I'm ok with that name-change :) I'll spin up a PR with all our discussed...

Sounds good, something I've noticed is that we will probably have to take extra care of stdout capturing. Right now when we create a new block there are multiple things...

Haha ok then 🤣 Ohh 😮 yes that might actually work, but we would have to do something about the echos when creating a block as they will be captured...