Hrishi-Baskaran
Hrishi-Baskaran
Hello @koppor , I'm reviewing both `org.jabref.logic.quality.consistency.BibliographyConsistencyCheck.java` and its corresponding test file. I have a question regarding the usage behind `requiredFields` which is declared in the method `check`: https://github.com/JabRef/jabref/blob/main/jablib/src/main/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheck.java#L105 The...
@koppor Okay, it seems like a large number of tests need to be refactored because they rely on the old incorrect, required field logic. I think it would be best...
Okay so it's actually around 10 or so unit tests that were failing. Here's an example of one that was failing: [https://github.com/JabRef/jabref/blob/main/jablib/src/test/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheckTest.java#L100](https://github.com/JabRef/jabref/blob/main/jablib/src/test/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheckTest.java#L100) The assertion expects the InProceeding with citation key...
> Please ensure the automatic check are green, otherwise no human will review it Thanks for telling me about this. I will update this on Friday.
Hello I'm very sorry about being inactive. I was going through a lot of other work I had to do and was planning on contributing again this weekend. Would it...