Hosch250

Select2 Accessibility Tweaks

2

Tested with the latest pre-release. The only problem with removing items is the tabindex="-1" prevents it from being focused, so the user can't remove an item with the keyboard. If...

Organization.GetAllForCurrent returning nothing with OAuth token

3

I created an OAuth app on GitHub, wired it into my app signin process, and everything works so far. ``` o.ClientId = Configuration["ClientId"]; o.ClientSecret = Configuration["ClientSecret"]; o.CallbackPath = "/signin-github"; o.Scope.Add("read:user");...

Implement MemberReturnsSelf

1

The following members all start an infinite recursion that blows up in a `StackOverflowException`. ``` AnyType Identifier { get { return Identifier; } } AnyType Identifier => Identifier; AnyType Identifier...

I found this article on Josh Varty's blog: https://joshvarty.wordpress.com/2015/03/30/lrn-quick-tips-dont-trust-syntaxnode-tofullstring/. We should go through and make sure each code fix generates the correct syntax tree; some of them may be using...

This is a common-ish pattern: MyType foo; if (MyType.TryParse("string", out foo)) { /* use foo */ } We can now write this as: if (MyType.TryParse("string", out MyType foo)) { /*...

This is a common pattern: var j = i as MyType; if (j != null) { /* use j here */ } We can now write this as: if (i...

Somewhere, someone may have code like the following: ``` try { } catch (SomeException e) { if (expression) { throw; } } ``` This can become: ``` try { }...

Conflicting naming styles with R#

5

R# says to use `_camelCase` naming for private static fields. VSD says to use `PascalCase` names for them. I usually use R#'s suggestions, but who is right here?

In this instance, you can use both `typeof` and `GetType()` to get the type of the parameter: ``` public class Foo { private void Bar(T test1, TR test2) { var...

The `AdditionalLocations` in a diagnostic is to provide a list of relevant information to the code fix. We should use these in several places to reduce the calculation done in...