Adam Johnson

Results 214 comments of Adam Johnson

> What would be the best way to do that? A different cmake_minimum_required or some sort of different check? We may not want to use `cmake_ minimum_required()` because this has...

Looks like this PR needs to be rebased to build.

Unfortunately, Python 3.9 has dropped support for Windows 7. Additionally, Windows 7 is now EOL. Therefore, any port that requires Python 3 to build will not build under Windows 7.

Unfortunately, `vcpkg_find_acquire_program(PYTHON3)` must *always* install the same version as the Python 3 port. Otherwise, ports that build python bindings and request the Python 3 executable will be broken.

Or the meson helpers could download Python 3.8 for meson to use.

We already have python3[deprecated-win7-support], which builds Python 3.9 with support for Windows 7.

Unfortunately, that won't fix the issue because vcpkg_configure_meson is using the python executable from vcpkg_find_aqcuire_program(PYTHON3) instead of the one built by the port. We'd need to change the meson scripts...

I'm going to continue to defer on this because imagers in general are a bit fiddly on the Python side. You've exposed a lot of things, for example the visitor...

This LGTM, but I think I would like to wait for client support in H-uru/Plasma before merging (this is you cue, @Deledrius 😄).

That sounds like a good idea, but isn't BGE gone in Blender 2.80 and above?