Daniel Hlaváček

Results 84 comments of Daniel Hlaváček

@Progi1984 Bro what is the status of this PR? There seems to be both modern and legacy code in the current develop?

@marwachelly Issue 1 is not related to this PR and not really an issue. There is not as much data as in other tables, that's why there is space and...

@marwachelly Regarding issue 1 - I think you could accept my word as a frontend maintainer and stop blocking this PR for it, as specified here: https://github.com/PrestaShop/PrestaShop/pull/27590#issuecomment-1128625874 There is no...

`$font_color = Tools::getBrightness($hex) > 128) ? '#000' : '#fff'`

We should just use normal html color input that symfony provides us. https://symfony.com/doc/4.4/reference/forms/types/color.html It's supported in all modern browsers - https://caniuse.com/input-color

Duplicate of https://github.com/PrestaShop/PrestaShop/pull/29182, but this solution seems better. The reset is there to fix an issue when you added the customized product to cart, but the ID of customization stayed...

@Dreimus Code style ;-) https://github.com/PrestaShop/PrestaShop/actions/runs/7919878241/job/21621615687?pr=35380