Results 544 comments of Ian Hickson

I would expect the first to become: ```dart static HandlerResponse handleRouteReplaced( ReplaceRoute action, RouteState state, ) { return HandlerResponse.updateOnly( state.copy(active: action.route, history: state.history), ); } ``` ...and the second to...

by turning it into a block with a return statement.

That's why [our `analysis_options.yaml` file](https://github.com/flutter/flutter/blob/master/analysis_options.yaml) says: ``` # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#consider-using--for-short-functions-and-methods ```

> If you were an automated formatter that was _only able to make whitespace changes_ to a given piece of code, what would you do with that code? I would...

> So should I just close this bug then? I don't know, this wasn't a bug I filed. I did file https://github.com/dart-lang/dart_style/issues/452 back in 2015, which was the bug requesting...

> OK. Having dartfmt automatically switch between `=>` and `{ return ... }` at this point would be a very large, disruptive change. An impactful change, one might say. >...

> If this code snippet is not formattable into a nice looking code It is. The Flutter style guide says the way you format that is you change it to...

Even better would be for \`\`\`dart blocks within dartdocs to be recursively formatted. :-)

> When building the flutter tools, the call to the pub process could be seen as an implementation detail, and we suggest running those calls with stdio turned off entirely....

> > Unfortunately these are run from bash scripts / batch files, so collecting the output and printing it on failure is non-trivial. Errors in these cases are rare but...