Ian Hickson
Ian Hickson
Wouldn't the test be basically what the code that found the crash in the first place was doing? (@christopherfujino if you think it should be test-exempt I defer to your...
cc @goderbauer
test-exempt: code refactor with no semantic change
> For instance, supposed you write a new file with a type Offset, this type could be imported from dozens of libs (that export Offset) Not sure I follow, can...
In the absence of anything else, presumably dart:ui is the right choice, since that's where it comes from. Presumably the IDEs that do autocomplete of imports can figure that out?...
> I don't have numbers but I think most of devs rely on IDE and analyzer suggestions/fixes. Most may, but we cannot abandon those who do not. > In this...
> the small set of users that don't use an IDE It's not a small set. It's probably the majority. Anyone reading tutorials, watching YouTube, editing a file in some...
I agree that the list of exports is bigger than what we want. What makes widgets.dart want to re-export rendering.dart's render objects? > Without an IDE the user will see...
(I think it would be useful to have a unit test that verifies that some identifiers _aren't_ exported, e.g. checking that RenderAligningShiftedBox isn't exported from anything other than rendering.dart, checking...
> > I agree that the list of exports is bigger than what we want. What makes widgets.dart want to re-export rendering.dart's render objects? > > Basically every `createRenderObject` method...