Results 544 comments of Ian Hickson

This seems almost guaranteed to cause some unexpected interaction, but I admit I cannot think what it might be... We should have tests for at least all of the following:...

> Started working on adding more test, @Hixie by proxy you mean the `PortalOverlay` widget right? I meant the `addDeferredChild` API, but I guess that's the same thing since it's...

@LongCatIsLooong I tried checking this out to play with it but it had a lot of conflicts (and many commits so it was hard to figure out how to resolve...

I found a problem with this approach. It breaks the invariant that Material relies on, namely that if it can find a `Material.of` during build, that guarantees that it can...

Another issue I ran into is that the logic that toggles the presence of the DebugBanner when you take a screenshot from the command line (hit `s` in the `flutter...

I suspect it's the same as the DebugBanner issue, but for what it's worth, selecting "Select Widget Mode" in the devtools also causes the framework to throw an assertion that...

One issue with the current API is that it doesn't provide an intuitive order for the overlayChildren. In general I would expect tree order to be respected as the paint...

The test in https://github.com/flutter/flutter/pull/105335#issuecomment-1192888019 is actually really good at showing this bug. Double tap each button, and the corresponding container just moves to the top of the rendering, even though...

I think if we want to use this with Overlay then getting the z-index right is actually pretty critical. There's no way to know when a random widget one uses...

It's hard for me to evaluate the OverlayLocation API because I don't really know what the use case is for me to use it. My concern with z-index ordering is...