Ian Hickson comments

Results 544 comments of


                                            Ian Hickson

[google_maps_flutter] Marker clustering support

@jokerttu Is this still something you are interested in working on? How can we help you?

remove temporary flag after migration

![LGTM](http://junkyard.damowmow.com/578) test-exempt: code removal

Fix Chip classes to respect iconTheme constructor param. fixes #111828

@timmaffett Thanks for your contribution. Per the comments above, it would be helpful if you could file a new PR with a clean commit with the changes, for easier review....

Not able to navigate using tab key when using nested Navigators.

Our new priority scheme is shifted by two from our old priority scheme which I believe means it is now consistent with Google's internal bug priority scheme.

ArchiveFile.string incorrect encodes non-ASCII data (causes dataloss)

Looks like the main constructor has a similar behaviour.

IOSink.add throws exceptions that cannot be caught

Aha, indeed! Thanks! I wonder if there's something we can do to make that clearer... you're right that it is documented, though I totally missed it when reading it before....

`unused_local_variable` flags parts of patterns that aren't used

True. I guess the thing I'm looking to keep is the self-documenting name, rather than avoiding underscores specifically.

`unused_local_variable` flags parts of patterns that aren't used

(Not a big deal for the named field, more of an issue for the positional ones.)

Added CircleAvatar Fit/Alignment to background/foreground images

I'm going to close this PR for now to get it off our review queue, but please don't hesitate to submit a new PR if you have the time to...

Fix TabBar Indicator doesn't show image

We're going to close this PR since it has outstanding comments. Thanks for your contribution; if you would like to follow up please don't hesitate to try sending a new...