Results 544 comments of Ian Hickson

Well presumably we added this feature for a reason. :-) That's what I would try to include in the explanations.

Stop-gap solution for what problem? That's what we should describe. That problem. And the better solution. :-)

test-exempt: refactor (in case the test is removed)

I'm concerned that this PR makes it easier to make links but does not make them work on web, where links are most common and where not matching the platform...

if i right click on the link, do i get the browser's menu?

I believe the `Link` widget in url_opener does that. cc @yjbanov Having it in url_opener wouldn't require that the developer use it to open a URL, it could still allow...

test-exempt: code refactor with no semantic change

test-exempt: code refactor with no semantic change But if you wanted to update `dev/bots/analyze.dart` to catch this that would be great! The trick is making sure there's no false positives.

This is great! (If you want to get really inception-like, there's a test for the analyze script in `dev/bots/test/analyze_test.dart`, but I don't think it's critical to add a test for...