Results 67 comments of Brett Birschbach

Potential solution is to simply check if `$(dialogContentSelector)` is found, if not, exit the `updateImageThumbnail` function. Note that the thumbnail for the featured page image is still correctly showing (it...

Here's the solution that I believe is working for me. Change the following code within `updatePageImageThumbnail()` in `image.js` ``` var thumbnailConfigPath = $(dialogContentSelector).find(pageImageThumbnailSelector).attr(pageImageThumbnailConfigPathAttribute); var thumbnailComponentPath = $(dialogContentSelector).find(pageImageThumbnailSelector).attr(pageImageThumbnailComponentPathAttribute); ``` to ```...

for the `ui.apps.structure` items... - should `/content/*` paths even be in here? - should we define the packageType as `application` since leaving it undefined gives this warning about "MIXED"? -...

Regarding the "duplicate file" issue for the `all` package. The file in sources looks like this: ``` ``` The file created in the `target` during build looks like this: ```...

Another warning in the build ``` [WARNING] Project is configured with outdated aemanalyser plugin version : 1.4.10 [WARNING] Please update to plugin version : 1.5.12 ``` And if you update...

FWIW a "poor man" implementation of this is to simply leverage FontAwesome on the text field that exists today - and then simply render the icon as: ``` ``` Posting...

This can be solved by adding a check to the validation message to see if the image is set. Add an `imageIsSet` function using the logic from the code that...

There's also a bug where the standard "required" check is preventing the dialog from closing for empty alt text after the selected image is cleared (though to be fair this...

This can be resolved by setting the `altTextFromDAM` property on initialization of JS code in `image.js` Update the following code: ``` altTextFromPage = $dialogContent.find(pageImageThumbnailImageSelector).attr("alt"); ``` to: ``` if (isPageDialog) {...

Note that https://github.com/adobe/aem-core-wcm-components/pull/2759/files may have resolved this issue, but in a heavy-handed way since we already have the data and there's no need to do another fetch from the DAM...