Brett Birschbach
Brett Birschbach
I was able to resolve this for my own project by creating a `SlingPostProcessor` that detects when an Accordion/Tab/Carousel component is having a child added that is not a Container,...
To fix this one, we just need to update the logic on how prefill values are fetched in `OptionItemImpl` Instead of: ``` String[] prefillValues = FormsHelper.getValues(request, options); ``` we can...
The fix for this one is quite a chore - basically the JS code for toggling the DM features on/off pays no heed to the page image checkbox, currently, so...
Next Gen DM support being removed? or updated? Can you tell me more?
ok, so then does that make all of the NGDM stuff in WCM Core unnecessary (i.e. can be removed)?
Thank you! We can close this issue out as soon as #2781 is merged!
**Issue 6:** Asset link test at `com.adobe.cq.wcm.core.components.internal.link.LinkBuilderImplTest#testLinkToAsset` is not running, b/c it is missing the `@Test` annotation. If you add `@Test` to run it, it breaks with the following exception:...
**Issue 7:** Hash is duplicated when it is in front of a query string and there is no URL path ``` // PASS assertEquals("https://test.com?categ=cat1#top", underTest.sanitize("https://test.com?categ=cat1#top", request)); assertEquals("https://test.com#top?categ=cat1", underTest.sanitize("https://test.com#top?categ=cat1", request)); //...
**Issue 8:** (minor issue) A fallback LinkImpl is always constructed in `LinkBuilderImpl::buildLink` b/c call to `orElse()` ``` return pathProcessors.stream() .filter(pathProcessor -> pathProcessor.accepts(decodedPath, request)) .findFirst() .map(pathProcessor -> new LinkImpl( pathProcessor.sanitize(decodedPath, request),...
For those looking for a workaround, updating my `default.jsp` to the following code seems to resolve: ``` Integer statusCode = (Integer) request.getAttribute(SlingConstants.ERROR_STATUS); if (statusCode == null) { statusCode = SlingHttpServletResponse.SC_INTERNAL_SERVER_ERROR;...