Hiranmaya Gundu comments

Results 9 comments of


                                            Hiranmaya Gundu

fix: get URL from credentials when building the Dockerfile

I'm not entirely sure if this is the correct fix -- just that it fixed my issue when I ran a test. I'm having difficulty running the entire suite locally....

fix: get URL from credentials when building the Dockerfile

@javierlopezdeancos we could, but it would have to be a private docker hub image that the project has access to (and presumably one that i personally don't have access to)

fix: get URL from credentials when building the Dockerfile

@javierlopezdeancos @cristianrgreco wanted to bump this for review 🙏🏽

fix: get URL from credentials when building the Dockerfile

Thank you @cristianrgreco! Appreciate it 😄

fix: get URL from credentials when building the Dockerfile

@cristianrgreco This issue only occured for me when I tried to build an image, so when doing ```js const container = await GenericContainer.fromDockerfile("./dockerfile").build(); ``` where the docker file is ```...

fix: get URL from credentials when building the Dockerfile

> When you run: docker-credential-gcloud list Could you confirm that any of the keys in the response matches the gcr registry from which you're trying to pull the image? A...

fix: get URL from credentials when building the Dockerfile

Yeah, I can push the changes later today!

fix: get URL from credentials when building the Dockerfile

@cristianrgreco made the changes!

Typescript compilation error in Node context

I just ran into this. Best I can tell, this is because in the `package.json`, the types point to the ESM types, and so typescript thinks its importing esm instead...