Martin Bies

@HechtiDerLachs: I have just checked the computational results. All of the above is correct and there is no bug (to the best of my knowledge). Our implementations follow the book...

Thank you for spotting this Lars! This is indeed the result that I am using, but somehow I forgot about these conditions. I have prepared a corresponding PR (see below).

It is definitely good that you brought this up! For instance, it definitely improved the code (see the above PR). Thank you! About the spectral sequences - I frankly don't...

Why not use deprecate? I was under the impression that then the old functions still work. The user might even be informed by this about the change of name? I...

I assume(d) sane input. The changes that I propose for `del_pezzo` are here: https://github.com/oscar-system/Oscar.jl/pull/1209/commits/59409e80ed2dca8c08c131c31b044c5a30f3561e

Thank you @benlorenz (for both the comment and the editing)! Any chance for a convenience method so that one can directly put the points into `PolyhedralFan`? Here are a few...

The terminology is from the toric geometry book by Cox-Little-Schenk for a toric variety X: - Div_T(X) = group of torus invariant Weil divisors on X - CDiv_T(X) = group...

I agree with @lkastner. From what I hear, we can all agree to the following long names (as proposed above): - `torus_invariant_weil_divisor_group`, - `torus_invariant_cartier_divisor_group`, - `class_group`, - `picard_group`, - `map_from_character_lattice_to_torus_invariant_weil_divisor_group`,...

I believe this is ready for review now. ~~Regarding the failure in the doctests, I am not sure if this is related to this PR. (On my local machine, I...

I have just force pushed. Many of the more "elementary" comments applied to all of the toric varieties and I tried to adjust all instances within the toric context. Points...