Henrique Jorge Barateli

Results 25 comments of Henrique Jorge Barateli

I opened the PR to fix this issue: [PR](https://github.com/chocolate-doom/chocolate-doom/pull/1659)

@fabiangreffrath If it is not much trouble, can you review my PR? This is my first time opening a PR in Github, so I may have missed smth.

Hmm, got it. I guess then only @fragglet can say for sure if this is a valid alteration. Looking the code commits, it seems he was the one who created...

Hey @fragglet, can you give some input if this code change makes sense?

@turol @JNechaevsky @chungy @mfrancis95 Could any of you with more Doom experience check if this change makes sense?

@fabiangreffrath Good point. Maybe we can allow Windows CE to behave as Vanilla then? It would only require us to remove the `defined(_WIN32_WCE)` from this [line](https://github.com/chocolate-doom/chocolate-doom/blob/22510a8be1b45a08f9d1ad341bd8f2d499502051/src/m_config.c#L2530).

It is more about simplifying the code and bringing Window CE behavior closer to the original Doom.

I think the above code is wrong. A gameskill of 0 corresponds to [sk_baby](https://github.com/chocolate-doom/chocolate-doom/blob/7a1f38ce328a1dd5fc39666e6b5afbd1bfb429fa/src/d_mode.h#L94), which is already covered in the [first if statement](https://github.com/chocolate-doom/chocolate-doom/blob/7a1f38ce328a1dd5fc39666e6b5afbd1bfb429fa/src/doom/p_mobj.c#L802). Also, a strict equality is insufficient, because...

I have the original installer, which I use to test some use cases with DOSBox. Any tools I can use to check if the compiled code treat it as unsigned?

Okay, here is what I did: 1. Grabbed a copy of Watcom C 9.01/386 from WinWorld (it was published in 1992 and it is probably the version used by Id...