Henrik Stanley Mortensen

Results 19 comments of Henrik Stanley Mortensen

I agree that an option to skip review when prompted, or maybe even an option to set a setting to always skip review would be very helpful and create a...

It seems like this functionality has now been added to winget, so it should now be possible to create a winget package based on .zip: https://github.com/hashicorp/terraform-ls/issues/114

> @CasperGN Did you manage to get it going? I have tested and done a review on the PR: https://github.com/backstage/backstage/pull/22648/files# The TL;DR is that moving the `instrumentation.ts` file outside of...

> @HenrikStanley Yeah, you would have to replace imports with `require`. Also, I think you haven't finished the review. Can't see any comments Right you are.. Review added now. It...

> @benjdlambert I think only a few instrumentations get applied properly with the previous setup. Now, with this new setup, every instrumentation from the list at the bottom of [this...

$ > @HenrikStanley Hmm, for me they are all there. Did you try to wait a bit. Metrics will not appear if they are not triggered at least once. In...

> @HenrikStanley Hmm, for me they are all there. Did you try to wait a bit. Metrics will not appear if they are not triggered at least once. In this...

Specifically for GitHub, the CLI has a great many options for manipulating a PR: https://cli.github.com/manual/gh_pr It comes pre-installed in the Github CI Runners, but would obviously need to be installed...

> @HenrikStanley do you want the markdown diff as stdout and/or as file? I assume both options can be useful, what do you think? any suggestions for parameter name and...

> As a workaround, I've been writing to the system `gitconfig` instead: > > ```json > "postCreateCommand": "sudo git config --system --add safe.directory ${containerWorkspaceFolder}", > ``` > > I agree...