HenningM
HenningM
Hi, I think this snippet would also fail on earlier versions of Node. `ws.send()` doesn't do any implicit JSON encoding of the data. To transfer an object you would need...
Hi @NewMountain, Thanks a lot for your interest in this library and your suggestion. I like the idea. If you'd like to submit a pull request for this I'd definitely...
Hi again @NewMountain, I think the functionality discussed in this issue would be a very interesting addition to the current library. I imagine a lot of `express-ws` users are already...
Hi @dhuber666, Thanks for your interest in this library. I think you might be confusing the [WebSocket](https://github.com/websockets/ws/blob/master/doc/ws.md#class-websocket) class with the [WebSocket.Server](https://github.com/websockets/ws/blob/master/doc/ws.md#class-websocketserver) class. The object passed to your callback would be...
Hi & thanks for the suggestion, I like the idea. Unfortunately I don't have time to look into this myself at the moment, but I'd definitely appreciate a PR for...
Hi @deckerrj, First of all: this looks like a solid pull request. Neat & concise solution to what I assumed would require a lot more fiddling and ugly hacks. I...
Hi @roastduck, Unfortunately this pattern would not be 100% straightforward to include in this library. The GET request for the WS upgrade is actually not fake at all. The WS...