Henning Kuntzschmann

Results 12 comments of Henning Kuntzschmann

Additionally, as stated in the first comment, implemented interfaces would be great to be detected. They need not occur in constructor nor in method argument list or as return type....

I made a patch for version 5.14.1 in case anyone else encounters the issue [amzn-button-login-render-gh-issue-1141.txt](https://github.com/amzn/amazon-payments-magento-2-plugin/files/9715016/amzn-button-login-render-gh-issue-1141.txt)

no problem, sorry that I couldn't fix the problem myself and make a pull request. I am not that familiar with magmi architecture

Seems to be fixed in Commit [dcbfe8b121b7767443c33289e0ab0173117771bb](https://github.com/magento/composer-root-update-plugin/commit/dcbfe8b121b7767443c33289e0ab0173117771bb) but never been released

@r-martins $proceed must not be called in every branch, that is the sense of the around plugin. The original method and `around` plugins following this very plugin are not called,...

It is even worse. It is not only an unnecessary invocation, it is completely unexpected. `InvokeAsync` has already returned a cancelled task to the caller (through registering to the cancellation...

> [Here](https://github.com/dotnet/winforms/discussions/12496#discussion-7490694) was some comments about InvokeAsync implementation (including cancellationToken). Didn't checked it by myself. The issues seem similar but are no duplicates. They are orthogonal.

Exactly. This is how it should work. But still, the behavior is currently different for the overloads in that all but one overload check the token again before executing the...

Looks pretty good. Seems to solve all issues. To the third (unsolved) point: I think the `IAsyncResult` returned from `BeginInvoke` suffers from the same issue. `EndInvoke` would hang forever, if...