Héctor Mendoza

Results 23 comments of Héctor Mendoza

> Same thing with this PR, we need to either manually update the goldens to include an API with `apiversion` (recommended), or we need to add a different specific test...

> > Correct me if I'm wrong, but we are using the `discovery-artifact-manager` repo as our golden > > No, we use the JSON here: https://github.com/googleapis/google-api-php-client-services/tree/main/generator/tests/testdata/golden_discovery I added a file...

Hey @cawa-93! Thanks for letting us know, will take a look on this for a proper solution.

Hey @fehrlich! Thanks for letting us know. Are you still having this issue?

Closed due inactivity. Please reach out again if you have further questions!

Hello! Thanks so much for reaching out, this definitely seems an issue with the API more than the library. Here is some information I found looking around related to the...

Closing this issue due inactivity. Please feel free to comment back if you still have the same issue!

Hello @bilal-ahmed-wpb ! @ajupazhamayil is correct, this code is automatically generated from protobuffs from each API team, that way they can make any necessary changes and the code gets generated...

Thanks for the input! Will take a look with the team and discuss any possible implementations that helps ease this concern for the next major release.