Sampo Kivistö comments

Results 221 comments of


                                            Sampo Kivistö

Improve mountebank performance by hoisting require calls

merged latest changes from master branch

Improve mountebank performance by hoisting require calls

@bbyars I opened another PR to update to npm 8 to fix circle ci https://github.com/bbyars/mountebank/pull/701

Improve mountebank performance by hoisting require calls

I merged latest changes and tests are now passing @bbyars

Manifest version 2 is deprecated

I tried with your work around and that makes unix (osx, linux) environments fail with following exception: ``` > cross-env TS_NODE_COMPILER_OPTIONS='{\"target\":\"es5\",\"module\":\"commonjs\"}' mocha --recursive --bail --opts config/mocha.opts undefined:1 {\"target\":\"es5\",\"module\":\"commonjs\"} ^ ```

refactor: replace deprecated String.prototype.substr()

Why not just use String.prototype.substring ? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring

inferno-compat issue: TypeError: _react.default.createContext is not a function

What kind of functionality you need from i18next framework? We are sing i18next package and calling translate method there.

inferno-mobx observer is incompatible with certain life cycle hooks

Hi, Thanks for reporting this issue. You seem to have good knowledge about mobx, would you like to send PR to fix the issue? The reason why those lifecycle methods...

inferno-mobx observer is incompatible with certain life cycle hooks

> am I understanding correctly that render can end up being called after componentWillUnmount if a state change ends up being async (at least if the change is forced)? That...

Function component returning null creates an empty text node in the DOM

Empty text node is used to track position of Component with null children. Ideally we dont want to do this, but it fixes some issues. We could try remove that...

Function component returning null creates an empty text node in the DOM

Yes, comment nodes could be used but they pollute DOM :( I need to check if same routines what we use for Fragments could be used to add support for...