Manifest version 2 is deprecated

[Spaceboy1337]

I got this error.

Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details.

[kentcdodds]

Interesting... Feel free to http://makeapullrequest.com if you want it fixed. Thanks!

[nightwolfz]

For anyone looking for a simple work around, you can escape the quotes like this:

cross-env TS_NODE_COMPILER_OPTIONS='{\\\"target\\\":\\\"es5\\\",\\\"module\\\":\\\"commonjs\\\"}' node test.js

[Havunen]

I tried with your work around and that makes unix (osx, linux) environments fail with following exception:

> cross-env TS_NODE_COMPILER_OPTIONS='{\"target\":\"es5\",\"module\":\"commonjs\"}' mocha --recursive --bail --opts config/mocha.opts

undefined:1
{\"target\":\"es5\",\"module\":\"commonjs\"}
 ^

[nightwolfz]

I didn't find a way to make it work for both unix and windows

[kentcdodds]

Yeah, probably should just write a node script..

[kentcdodds]

Closing due to inactivity

[Apidcloud]

Any news on this?

[kentcdodds]

Nope. Happy to look at a reproduction repository or pull request...

[Apidcloud]

Just pushed to a test repository: https://github.com/Apidcloud/TypeScript-Experiments/tree/mochaTest

Running npm run test-working works as expected as it uses the 'set' way of setting an environment variable. Using cross-env (try to run npm run test-notWorking) doesn't work though.

You can also check the output script mentioned above with npm run test-crossEnv

Thanks again!

[kentcdodds]

Great! Thanks for that! Could you did a little deeper? Have you tried escaping your backslashes? Or maybe using the other cross-env binary?

[Apidcloud]

I have ran a few more tests, but I can't figure a solution for both Linux and Windows (can't test on OSX).

Windows works with triple backslash (\\\), whereas Linux only works with one backslash (\).

Changing from cross-env to cross-env-shell doesn't make a difference.

Thanks!

Edit: Updated the repository with missing dependencies, so you shouldn't have a problem to test it now.

[kentcdodds]

Thanks for all the work so far on this. v5.0.0 introduced a new binary you can read about in the docs called cross-env-shell

I'll try to find some time to give this a look, but I can't promise anything. You're more likely to get it fixed if you can dig further.

[kentcdodds]

This appears to have worked:

"test-crossEnv": "cross-env TS_NODE_COMPILER_OPTIONS={\\\"module\\\":\\\"commonjs\\\"} node test/core/cross-env_test.ts"

I removed the single quotes around the { and }

[Apidcloud]

I did a quick test and that only seems to work on windows. Linux seems to need the single quotes.

Edit: Actually you are right, removing the single quotes and keeping the triple slash for every double quote seems to work on both Windows and Linux!

[kentcdodds]

I'm on a Mac :)

[Apidcloud]

Yeah, my bad! I checked properly and it seems to work. You were rather quick finding a working option lol

[kentcdodds]

Glad we've got something that works for you :) It may be useful to include a note in the README about this. Feel free to make a pull request :)

[Apidcloud]

I will be sure to do that today then :) Thanks again!

[JoePercy-Capp]

In case this helps anyone who is as stuck as I was five minutes ago... This works:

TS_NODE_COMPILER_OPTIONS={\\\"module\\\":\\\"commonjs\\\"}

This doesn't (I had spaces after { and before } - couldn't see how it was different from the examples above until I copy-pasted):

TS_NODE_COMPILER_OPTIONS={ \\\"module\\\":\\\"commonjs\\\" }

(at least for me, on Windows)