Siyang Tang

Results 63 comments of Siyang Tang

@Yukang-Lian has heavy tasks currently and passes this task to me. I'll try to work on it.

Hi @SaintBacchus , just for disscussion, how about replace the ConnectContext#resetExecTimeout by ``` java public void setExecTimeout(int timeout) { executionTimeoutS = timeout; } ``` And in StmtExecutor#handleInsertStmt, use ```java context.setExecTimeout(Math.max(context.getSessionVariable().getInsertTimeoutS(),...

> @TangSiyang2001 thanks for suggestions. I had modified it. > > And I place the `Math.max` in the function `setExecTimeout`, how do you think about these? > > ``` >...

> I think use `resetExecTimeForInsert` to do these job is better than `setExecTime` since it had called three times. Sorry for late reply, you may look at my comment above....