HarvsG
HarvsG
@frenck Could you kindly move the PR to 'needs review' or 'review in progress' on the projects board please. I closed and re-opened as per @emontnemery 's suggestion to force...
Tagging reviewers @dgomes and @emontnemery
Bumping as has been another week @dgomes @emontnemery @frenck
Bumping as has been another 3 weeks @dgomes @emontnemery @frenck
> @HarvsG need help finishing this PR ? ~Yup just the changes to the tests. I have not done much work on tests before and a bit pressed for time...
@dgomes I have done all your suggestions. I have tried adding myself as a codeowner but pre-commit checks disallow it: ``` hassfest.................................................................Failed - hook id: hassfest - files were modified...
> Sorry to have lead you in the wrong direction, you add yourself through the manifest file Turns out I had to ad the modified CODEOWNERS file as well as...
@dgomes Are you happy I have resolved your suggestions and queries? Build ~should now pass~ now passes as well.
Great. I notice another reviewer is listed but I don't know if they are required. So apologies for (possibly) requesting a review unnecessarily.
Anything else I need to do before merge?