Hardik Pawar comments

Results 64 comments of


                                            Hardik Pawar

Readable code, function docstring and doctests

I have removed the added doctests. Now, there is only one change - the code.

Readable code, function docstring and doctests

I have opened the PR #10891 which has the added doctests. Thanks!

Readable code, function docstring and doctests

Added the tests that have been merged to master.

Readable code, function docstring and doctests

Renamed the variables. Adding strict=True produces this error: TypeError: sort() takes at most 2 keyword arguments (3 given) Edit: Fixed the above error by adding strict=True in the zip function

Readable code, function docstring and doctests

I'll add the changes tomorrow. Thanks for highlighting the issues.

Readable code, function docstring and doctests

I have added the input validation check for `capacity` and `max_items` variables, and updated the doctests accordingly.

Readable code, function docstring and doctests

I have corrected the algorithm.

feat: Add `AllConstruct` new algorithm with Junit tests

I have fixed the issue with the build job.

feat: Add `RandomScheduling` new algorithm with Junit tests

I have fixed the build issue.

Attention layer does not accept output of previous layers in functional API

Thanks!