Hans Mackowiak

Are we sure about that array type? https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/types.html#array says: > This type is deprecated since 3.4.0, use [json](https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/types.html#json) instead. right now, I get: > Unknown column type "array" requested. Also...

> I would suggest ti use `opt` Yeah, but we recently removed the Add-opens from the run scripts in favor of AddOpens in the Manifest File So it would be...

I added a Draft PR, it doesn't address the product attribute, but the templates all have better protection functions now

> Wouldnt it be better to dispatch an `_after` event? The problem right now is that the existing event is either called before or after the calculator process If you...

Yeah, that annoyed me when i was looking at the templates Does it need `@see` if it already has `@var this`?

`canDisplayGiftmessage()` could be existing methods, but I still touched them, so they should be updated?

> To not break anything i'd not change existing methods. imo, if `getLayout->getBlock` returns something else than Mage_Core_Block_Abstract, their code is already broken, they just don't know it yet

> What do think about to use `isModuleOutputEnabled` to show template parts? What exactly do you mean? is it about the move of `$this->helper('giftmessage/message')->getIsMessagesAvailable('order_item', $parentItem)` into Block logic?

> Can you try to create an order with a downloadable product? > > > Uncaught Error: Class 'Mage_Giftmessage_Helper_Message' I don't have a working shop right now, (vacation) But can...

My ideas so far to combine the points above: * new FCollectionInterface that extends from Collection Interface * new FCollectionAbstract that extends from ForwardingList/AbstractListDecorator, (so we could inject Immutable/Unmodifiable Views?)...