Hans Mackowiak

Results 432 comments of Hans Mackowiak

@sreichel yeah, probably but I mean it more like it couldn't find a place where `core/html_date->getEscapedValue` is called there are some places that use this block with format: * Mage_Catalog_Block_Product_View_Options_Type_Date...

> Aside from dependencies performance should also be considered. Zend_Date / Locale handling is extremely slow. There ought to be significant benefits getting away from those, but would be interesting...

sad `no symfony` noises xD Also, you might need to look at this: ``` @deprecated Calling `validate()` directly from rules is deprecated. Please use {@see \Respect\Validation\Validator::isValid()} instead. ```

for the current changes in this MR, Symfony Validator might be easy too. the bigger use would be that we could validate entire objects like Customer Address at once Also...

@stof but `MimeTypes::MAP` is hidden from my grasp, so I can't rely on an already existing list

do you have a mac to test the scripts? can you update the forge.command script too? #5548 it still misses the version checks from the forge.sh

> > do you have a mac to test the scripts? > > No, I don't have a mac to test scripts, but the changes I made are POSIX-compliant. It...

it seems we can still force MacOS to use sh for the *.command file, or would that be ignored? https://github.com/Card-Forge/forge/blob/78bff0a8f96d6e7490e0a2297a7ad29d0b4c7dc0/forge-gui-desktop/src/main/config/forge.command#L1-L3

@tehdiplomat @Agetian @kevlahnota can someone check this MR?

the problem with such token images, like Embalm or Eternalize too, is that they could be misleading * Tah-Crop Skirmisher with Embalm * Proven Combatant with Eternalize seemingly create Tokens...