Elijah Hamovitz

Results 80 issues of Elijah Hamovitz

This is a big one! This PR proposes that we enable the optional `Layout/ClassStructure` Rubocop rule, which will enforce strict ordering of different types of code blocks within a class...

code-hygiene

Follow-up to https://github.com/code-dot-org/code-dot-org/pull/57621, which enforced the use of inline private methods. Also see https://github.com/code-dot-org/code-dot-org/pull/50709 for more discussion on the topic. Although it is nice to see explicit declarations for each...

code-hygiene

## Screenshots interface | screenshot --- | --- Login; last attempt | ![image](https://github.com/code-dot-org/code-dot-org/assets/244100/4822f5ed-898d-4c5d-adde-1f3adb71ba41) Login; account locked | ![image](https://github.com/code-dot-org/code-dot-org/assets/244100/09fe7b20-64c1-4f08-b93a-405edf2ad415) "Unlock Account" email |![image](https://github.com/code-dot-org/code-dot-org/assets/244100/0bec1a1b-ee37-4c9c-ab37-4f75a7ec50b8) Login; post-unlock | ![image](https://github.com/code-dot-org/code-dot-org/assets/244100/34d2a926-a7d7-44ab-8cf2-e49f8a79c3c0) email link clicked after...

add a basic implementation of a session store that converts cookie-based sessions to redis-based sessions with no user impact ## Links ## Testing story ## Deployment strategy ## Follow-up work...

Placeholder PR for removing the instrumentation added in https://github.com/code-dot-org/code-dot-org/pull/57357 once we've finished the experiment. ## Links ## Testing story ## Deployment strategy ## Follow-up work ## Privacy ## Security ##...

Prereq for https://github.com/code-dot-org/craft/issues/459

![image](https://user-images.githubusercontent.com/244100/49627550-4a30fa80-f994-11e8-877b-59596a7e8c4e.png)

in https://studio.code.org/s/aquatic/stage/1/puzzle/11, the static conduit image looks like it has some visual glitches; the animated version of the thumbnail makes it clear what's going on, but it's not at all...

![image](https://user-images.githubusercontent.com/244100/33622272-41661970-d9a2-11e7-9d70-c5cd2cf36b49.png) What should probably happen is that placing rails (or any other action plane block) in a space with a decoration block should just destroy that decoration block

bug
help wanted

After https://github.com/code-dot-org/craft/issues/459 is addressed, we can replace all static methods like `Position.add(left, right)` with instance methods like `position.add(other)`

enhancement