Elijah Hamovitz

Results 27 comments of Elijah Hamovitz

Ahhh, I had been wondering why it was necessary to manually specify the type in this frontend. Yeah, with a working `json` gem it should be possible to dramatically simplify...

As the Rubocop documentation points out, there is one difference in behavior between these two approaches specifically when it comes to empty enumerables: ```ruby irb(main):001:0> [].map(&:to_i).reduce(:+) => nil irb(main):002:0> [].sum...

I feel more conflicted about this one the more I think about it. After some consideration and discussion with the infrastructure team, I think what I'd most prefer here is...

Bethany, I've found that `rubydoc.info` links are a bit unreliable, and sometimes just spontaneously fail to load. Can you check the link again? It's working for me currently

I'm not 100% convinced of the safety of this one, but it's probably fine. We leverage Redcarpet quite a bit, and in a few different ways; not only for markdown...

This PR is a continuation of #56177, which was mis-closed by the Git LFS migration (#55759). ### Previous Comments: ### Previous Reviews:

> Do we need to update our Rack Request extension? It seems to try to decrypt the session cookie to extract the user_id, I'm guessing so that Pegasus knows who...

> Is this providing an edit-form for DCDO values stored in DynamoDB? Yep! > How does this related to the unit test in-memory store? Can settings be set on that?...

See https://github.com/code-dot-org/code-dot-org/blob/7e8bd89106b4350a6737d647fbc4a2638b9cd1be/lib/dynamic_config/environment_aware_dynamic_config_helper.rb#L5-L18 for the dirty details

This PR is a continuation of #53055, which was mis-closed by the Git LFS migration (#55759). ### Previous Comments: ### Previous Reviews: - **pablo-code-org approved** -