Halimao

Results 54 comments of Halimao

@MariusVanDerWijden I have found the reason for `checkAccounts` issue. 1. The following call chain will start `watcher`, and call `scanAccounts` after about `500ms`: `Keystore.NewAccount/Keystore.Delete -> Keystore.refreshWallets -> accountCache.accounts -> accountCache.maybeReload`...

@MariusVanDerWijden Upgraded to use `file cache lock`, to ensure `delete account` and `scanAccounts add account` won't process at the same time.

> I'm not sure about the changes in `checkEvents`. For some events, the order matters. For example, wallet addition and removal should be emitted in the correct order. We can't...

> I wonder if the changes to accounts/keystore/keystore_test.go [here](https://github.com/ethereum/go-ethereum/pull/30146) fix the account issue you mentioned? There is no event missing. All events were handled correctly indeed, no events were missing...

@rjl493456442 Found `TestUpdatedKeyfileContents` is still flaky. I don't think #29867 fixed the issue. ```shell --- FAIL: TestUpdatedKeyfileContents (2.11s) account_cache_test.go:399: Emptying account file failed account_cache_test.go:400: wasn't notified of new accounts FAIL...

@gmalouf Hi sir, could u plz help me review this PR, since it's similar to PR #5886 and this new feature won't take effect by default

> @Halimao this is cool, i think the original ticket requests to NOT output to stdout at all, vs an alternate screen, with that it may be we do not...

@ramin @Wondertan Hi sir, any new progress here?

I am sorry, I think changing http client timeout will affect all api requests based on this client. Do I miss something here? For example, I wanna set 5s timeout...