Halimao

Results 54 comments of Halimao

@bingcicle Hi, I have drafted a PR to close this issue, again looking forward to your review~

@sdankel GM sir, looking for your review again😀

@sdankel Hi sir, looking forward for your review again😀

> Question about the exporting format in the images. It looks to be Json-ish. > > [Here](https://github.com/FuelLabs/sway-applications/blob/354bac23f11db6b2f89df53b46a8afe43c31911d/AMM/project/fuel-toolchain.toml#L1-L6) is an example of a toolchain file and they look to be formatted...

@Braqzen @sdankel Hi sir, is there anything that needs to be added for this pr?

> Running `toolchain export` without any args / options I see the following > > ![1](https://private-user-images.githubusercontent.com/103777923/295647998-8c48814f-257c-4ab1-bbed-30c424c873a3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ5Mzg2MjIsIm5iZiI6MTcwNDkzODMyMiwicGF0aCI6Ii8xMDM3Nzc5MjMvMjk1NjQ3OTk4LThjNDg4MTRmLTI1N2MtNGFiMS1iYmVkLTMwYzQyNGM4NzNhMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDExMVQwMTU4NDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wYzBhZTYzZjViOTg2MjkxMWUzYmJmNTA1YjcxMzI3ODg4ZmQyMmYzMWQzMjQ5YWVlYzZkZWVjMDZmNmQyMTJjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.oZIN5UiEQBHrZ1lZ5zk_6dWyzKX9snvJ-3dZhB7c4Do) > > I would move the message asking for input onto a new line...

> I would also split the tests a bit further to group them in order to reduce the cognitive load and make it easier to read. > > I would...

> This test should pass: > > ``` > ExportCommand { > name: None, > channel: Some("beta-3-x86_64-apple-darwin".to_string()), > force: true, > }, > &INPUT_NO[..], > ) > ``` One of...

> What I'm saying is if I'm on beta-3, the toolchain name is beta-3-x86_64-apple-darwin. If I just run fuelup toolchain export, I expect it to work. Currently it gives me...

@MariusVanDerWijden I have Dumped out the difference between `live` and `wallets`, but this does a little help to find the bug. It's more difficult to fix `checkAccounts` than `checkEvents`, I'm...