HD Yi
HD Yi
@adam-ah The value is slightly different is because the definition of emd given in [Fast and Robust Earth Mover’s Distances](http://www.cs.ucf.edu/courses/cap6412/spr2014/papers/pele-ICCV2009.pdf) is different from the standard emd distance.
> Best of luck @HaidYi on the job interviews! > > Yea the comments about updating the Dockerfile are definitely not super pressing, might just be nice to fix eventually....
What's your currently input? We have updated multiple version now.
Problem solved by replace `hmmscan` with `hmmsearch`
@jfy133 Thank you for the comments and suggestions. I will fix all the problems one-by-one. As I don't want this PR corrupt other screening steps, I will do a more...
@jfy133 Sorry for the late reply. I am working on other things recently. I have fixed all the issues above and it's ready for a review. Thanks!
@jfy133 Sure, I have fixed that issue, which is a typo. Now, it only has a linting issue, which feels like a document-related one. Passed all the pipeline tests in...
@jfy133 Thank you for fixing the remaining issues. Any other things left to do from my end before merging it?
@jfy133 Please review it again. All the issues you raised have already been resolved in the current codes.
> I see you've not got to this yet @HaidYi , will check again next week :) (no rush though!) @jfy133 Sure, I will get back to working on it...